Task #87973: LinkGeneratorTests should use a proper backend user context for versioned link generation checks - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #87973

closed

LinkGeneratorTests should use a proper backend user context for versioned link generation checks

Added by Benjamin Franzke over 5 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Tests

Target version:

Candidate for patchlevel

Start date:

2019-03-21

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

Currently typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php linkIsGeneratedForPageVersionDataProvider() does only specify a workspaceId, but misses a backend user id.

In that case the workspace id was ignored ignored by the test framework, see TYPO3\JsonResponse\Middleware\BackendUserMiddleware: https://github.com/TYPO3/testing-framework/blob/3d03574ce47d247f1c893cd8bd49292982418d0b/Resources/Core/Functional/Extensions/json_response/Classes/Middleware/BackendUserHandler.php#L53-L54

Some of the current todos fail because the test context is wrong.

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60302

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60302

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60302

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60328

Actions

Copy link

Updated by Benjamin Franzke over 5 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 3cc78c965fe1e627d502f8a930caa9fe5ee153e9.

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60328

Actions

Copy link