TYPO3 Core

My current solution:

    /**
     * Working with own QueryBuilder queries does not respect showHiddenContent settings of TYPO3, that's why
     * we have to manually remove Hidden constraint from restriction container.
     *
     * @param QueryBuilder $queryBuilder
     */
    public function addVisibilityConstraintToQuery(QueryBuilder $queryBuilder)
    {
        if (version_compare(TYPO3_branch, '9.4', '>=')) {
            $context = GeneralUtility::makeInstance(Context::class);
            $showHiddenRecords = (bool)$context->getPropertyFromAspect(
                'visibility',
                'includeHiddenContent',
                false
            );
        } else {
            $showHiddenRecords = (bool)$this->getTypoScriptFrontendController()->showHiddenRecords;
        }

        if ($showHiddenRecords) {
            $queryBuilder->getRestrictions()->removeByType(HiddenRestriction::class);
        }
    }

Problem still exists. If you want to test that, you can install events2 and create a hidden and a visible event. Go into FE and it will work. Of cause, as I have added a patch for that into events2.
Please remove the body of this method to get the original Core handling:
https://github.com/jweiland-net/events2/blob/master/Classes/Service/DatabaseService.php#L549

As you will see, the hidden record will never be visible in FE.

Stefan

Ok, maybe I should have asked more precisely:

From what I can see in the code, where do you add the Frontend restrictions?

What I'm missing is: `$queryBuilder->setRestrictions(GeneralUtility::makeInstance(FrontendRestrictionContainer::class));`

That's what I meant with my previous comment. If you do not take care, you only get the DefaultRestrictionContainer - which does not care about frontend related settings in TSFE. If you are in frontend context, use the FrontendRestrictionContainer.

For example, this is how extbase does it:

        $queryBuilder = $this->connectionPool->getQueryBuilderForTable($tableName);
        if ($this->environmentService->isEnvironmentInFrontendMode()) {
            $queryBuilder->setRestrictions(GeneralUtility::makeInstance(FrontendRestrictionContainer::class));
        }

Hello Susi,

thank you for that hint. I remember that I have debugged the new Doctrine thing at a very early state where TYPO3 Core adopt the correct RestrictionContainer for the developer automatically:

https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Database/RestrictionBuilder/Index.html (-> first blue note)

I didn't noticed that this behavior was changed in the past.

OK...much to do. I have to check various extensions, where I have build my own Queries for FE with TYPO3's QueryBuilder.

So, yes, this ticket can be closed now, as my problem is solved with FrontendRestrictionContainer

Stefan