Bug #88377
closedPage tree delete does not perform error checking
100%
Description
Running TYPO3 9.5.7.
Deleting a page via the page tree does not seem to perform error checking in this particular scenario, the page tree just reloads without the deletion being performed and without showing an error message:
- Create a page (lets call it page A) with a subpage.
- Make sure that in user settings -> Edit and Advanced functions -> "Recursive Delete(!): Allow ALL subpages to be deleted when deleting a page" is disabled. Should be default for new users.
- Right click on page A in the page tree and choose "Delete".
Expected behavior: An error message is shown.
Actual behavior: The page tree reloads without showing any error message. An error message is only shown when navigating to a new backend site ("Attempt to delete page which has subpages").
This bug may not be exclusive to this specific scenario when deleting pages via the context menu, I haven't checked whether other errors are properly handled.
This seems to be a regression. In TYPO3 6.2 in the same scenario, an error message notification pops up:
Exception
[1.0.-1]: [newlog()] Attempt to delete page which has subpages
Updated by filigivuji filigivuji over 5 years ago
- Related to Bug #87416: Page is not deleted through the context menu if the site has translations and the page was currently selected added
Updated by filigivuji filigivuji over 5 years ago
- Subject changed from Page tree delete does not perform error checking (recursive deletion) to Page tree delete does not perform error checking
This issue is related to #87416, which was solved by implementing a change that uses AJAX to perform deletions. See this change set -- it is obvious that the AJAX call in the change does not perform any error checking at all. So the same bug (no error messages) probably applies to other situations as well, e.g. when deleting a page that was already deleted from another tab or trying to delete a page the user does not have the appropriate permission for.
I have tested the above scenario on 9.5.5 and the issue does not happen there as in the iframe a page is loaded which in turn shows the error message boxes immediately.
Updated by Riccardo De Contardi almost 5 years ago
This issue is still present on 9.5.9 and 10.1.0-dev (latest master)
Updated by Gerrit Code Review almost 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61954
Updated by Gerrit Code Review almost 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61966
Updated by Andreas Fernandez almost 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f4e7e7df5bc915d3a81d18a228984734b90d3257.
Updated by Gerrit Code Review almost 5 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61966
Updated by Andreas Fernandez almost 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset 0a4890e33c0264744c5f65bd2ff7fdb398a6a324.