Bug #88486
open
Language fallback chain is lost with setting "Show Content from Page"
0%
Description
To reproduce:
Languages:- /de/ (Default)
- /en/
- /en-us/ (Fallback Type "strict", Fallback to other Languages: "EN")
- Root
- Page 1 [/page-1/, uid: 1, content_from_pid: 2]
- Page 2 [/page-2/, uid: 2]
Frontend:
/en-us/page-1 -> Missing language fallback chain in LanguageAspect. As a result, the navigation is no longer displayed
/en-us/page-2 -> Works. The navigation in language EN is displayed.
https://github.com/TYPO3/TYPO3.CMS/blob/v9.5.7/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php#L1693
At this point the LanguageAspect will be ovewritten with a new LanguageAspect without fallback chain.
This modified LanguageAspect is used for menu generation (https://github.com/TYPO3/TYPO3.CMS/blob/v9.5.7/typo3/sysext/frontend/Classes/Page/PageRepository.php#L634).
Updated by Susanne Moog almost 5 years ago
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review almost 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62883
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62883
Updated by Benni Mack almost 4 years ago
- Status changed from Under Review to Accepted
Updated by David Hedden almost 4 years ago
I think the main problem is that the TSFE gets copied, but the referenced classes are still the same.
So after the call to getPageAndRootlineWithDomain that changes the context, it also gets changed for the original TSFE.
An easy fix would be to get the context before creating the copy and restoring it, after that only the contentId from the language aspect has to be inserted.
But that still leaves room for future bugs from copying the TSFE.
Updated by Sruthi Kumar G over 2 years ago
This issue still exists in v11.5.10 as well.
The default language is DE, on FR translation added content_from_pid as EN translated page.
In FR page frontend, EN content is shown but navigation is missing.
Updated by Oliver Hader about 2 years ago
- Sprint Focus deleted (
On Location Sprint)