Feature #88643

Replace SwiftMailer with Symfony/Mailer

Added by Benni Mack 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Miscellaneous
Start date:
2019-07-05
Due date:
% Done:

100%

PHP Version:
7.2
Tags:
Complexity:
Sprint Focus:

Subtasks

Bug #88692: SendCommandTest is skipped due to a warning since symfony/mailer mergeClosed


Related issues

Related to TYPO3 Core - Bug #88702: EmailFinisher - Recipients - Cannot unpack array with string keys Resolved 2019-07-08
Related to TYPO3 Core - Bug #89083: MailMessage setFrom and setTo are throwing exceptions Resolved 2019-09-04

Associated revisions

Revision 2604de30 (diff)
Added by Benni Mack 4 months ago

[!!!][FEATURE] Replace SwiftMailer with symfony/mailer and symfony/mime

SwiftMailer is not in active development anymore
as the author created the successor symfony/mailer
and symfony/mime packages to create and send
emails.

This is a breaking change, as PHP mail() is not
supported anymore. This is now automatically
switched to "sendmail".

In addition \Symfony\Mime\Email has a different
signature than \Swift_Message, which will
cause some trouble, however we've managed
to overcome most of that functionality to
stay backwards-compatible.

Also, all extensions extending from SwiftMailer
will fail as the package is be removed
with this patch.

Spooling has been reimplemented as direct transport
methods (DelayedTransportInterface) instead of
Symfony Messaging for the time being.

Used composer commands: * composer require symfony/mailer symfony/mime * composer remove swiftmailer/swiftmailer

Resolves: #88643
Releases: master
Change-Id: Ic02db633392f1d0d7b7061e7b322435f892d2c04
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61152
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Georg Ringer <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Georg Ringer <>

Revision 3b8a6dbc (diff)
Added by Benjamin Franzke 4 months ago

[BUGFIX] Adapt SendEmailCommandTest for symfony/mailer

The tests produced a warning which didn't cause CI to abort,
but the test was actually skipped:

1) TYPO3\CMS\Core\Tests\Unit\Command\SendEmailCommandTest
::executeWillFlushTheQueue
Trying to configure method "flushQueue" which cannot be configured
because it does not exist, has not been specified, is final, or is
static

Resolves: #88692
Related: #88643
Releases: master
Change-Id: I3077a011e19050986585e9c788f5db03d18595d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61233
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Alexander Schnitzler <>
Tested-by: Benjamin Franzke <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Alexander Schnitzler <>
Reviewed-by: Benjamin Franzke <>

Revision 9fec751a (diff)
Added by Frank Naegler about 1 month ago

[BUGFIX] Add tests and fix broken MailMessage

This patch add tests for the MailMessage class and fix broken
functionality since migration to Symfony Mailer.

Resolves: #89083
Related: #88643
Releases: master
Change-Id: Ieb7616aa24cee26505d0e2260a26b56713caebc1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61908
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Daniel Goerz <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61152

#2 Updated by Gerrit Code Review 5 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61152

#3 Updated by Gerrit Code Review 5 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61152

#4 Updated by Benni Mack 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Susanne Moog 4 months ago

  • Related to Bug #88702: EmailFinisher - Recipients - Cannot unpack array with string keys added

#6 Updated by Benni Mack 4 months ago

  • Status changed from Resolved to Closed

#7 Updated by Frank Naegler about 1 month ago

  • Related to Bug #89083: MailMessage setFrom and setTo are throwing exceptions added

Also available in: Atom PDF