Bug #88709

mail config input fields in Installation-Wide Options get autocompleted with TYPO3 backend username/password

Added by Jonas Eberle 15 days ago. Updated 1 day ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2019-07-09
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After editing some "Installation-Wide Options" with Firefox, I noticed my username and password turned up in LocalConfiguration.php...

(at least) these 2 fields should have autocomplete="off"

<input type="password" value="" data-path="MAIL/transport_smtp_password" class="t3-install-form-input-text form-control t3js-localConfiguration-pathValue">

<input type="text" value="" data-path="MAIL/transport_smtp_username" class="t3-install-form-input-text form-control t3js-localConfiguration-pathValue">

Screenshot_20190709_142818.png View (15.9 KB) Jonas Eberle, 2019-07-09 14:28

Associated revisions

Revision ebad91ff (diff)
Added by Guido Schmechel 1 day ago

[TASK] Disable autocompletion in Install Tool settings

To prevent unwanted entries, the autocomplete attribute
in the Install tool is added with the `off` property.

Resolves: #88709
Releases: master, 9.5
Change-Id: I3c0a343fd76170f6cc37e5e87ad9a5d5d9a52fb9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61331
Tested-by: Tymoteusz Motylewski <>
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Andreas Fernandez <>

Revision 09ee7f61 (diff)
Added by Guido Schmechel 1 day ago

[TASK] Disable autocompletion in Install Tool settings

To prevent unwanted entries, the autocomplete attribute
in the Install tool is added with the `off` property.

Resolves: #88709
Releases: master, 9.5
Change-Id: I3c0a343fd76170f6cc37e5e87ad9a5d5d9a52fb9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61337
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Guido Schmechel 11 days ago

This would be a common UX topic. Should we turn off the AutoComplete for all fields? I would agree.

Affected file: typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html

#2 Updated by Gerrit Code Review 4 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61331

#3 Updated by Gerrit Code Review 2 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61331

#4 Updated by Gerrit Code Review 1 day ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61331

#5 Updated by Gerrit Code Review 1 day ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61337

#6 Updated by Guido Schmechel 1 day ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF