Bug #88865: RecordsXmlSitemapDataProvider does not strip logical operator for additionalWhere - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #88865

closed

RecordsXmlSitemapDataProvider does not strip logical operator for additionalWhere

Added by Rémy DANIEL almost 5 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Rémy DANIEL

Category:

SEO

Target version:

next-patchlevel

Start date:

2019-07-30

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

CodingNight

Complexity:

easy

Is Regression:

Sprint Focus:

Description

RecordsXmlSitemapDataProvider does not strip logical operator for additionalWhere, but PagesXmlSitemapDataProvider does it.

The documentation of RecordsXmlSitemapDataProvider config.additionalWhere shows a AND logical operator, but this will leads to an invalid SQL query like this:

... AND (AND (no_index = 0 OR no_follow = 0)) ...

To prevent this, \TYPO3\CMS\Core\Database\Query\QueryHelper::stripLogicalOperatorPrefix() should be used on config.additionalWhere.

[1] https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/XmlSitemap/Index.html#xmlsitemapdataproviders

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions

Copy link

Updated by Rémy DANIEL almost 5 years ago

Assignee set to Rémy DANIEL

Actions

Copy link

Updated by Susanne Moog almost 5 years ago

Tags set to CodingNight

Actions

Copy link

Updated by Susanne Moog over 4 years ago

Target version set to next-patchlevel

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61523

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions

Copy link

#10

Updated by Rémy DANIEL over 4 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 0f8fcd748397578ba164739e736b0acd17e4760d.

Actions

Copy link

#11

Updated by Gerrit Code Review over 4 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61612

Actions

Copy link

#12

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61612

Actions

Copy link

#13

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61612

Actions

Copy link

#14