Project

General

Profile

Actions

Bug #88865

closed

RecordsXmlSitemapDataProvider does not strip logical operator for additionalWhere

Added by Rémy DANIEL over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
SEO
Target version:
Start date:
2019-07-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
CodingNight
Complexity:
easy
Is Regression:
Sprint Focus:

Description

RecordsXmlSitemapDataProvider does not strip logical operator for additionalWhere, but PagesXmlSitemapDataProvider does it.

The documentation of RecordsXmlSitemapDataProvider config.additionalWhere shows a AND logical operator, but this will leads to an invalid SQL query like this:

... AND (AND (no_index = 0 OR no_follow = 0)) ...

To prevent this, \TYPO3\CMS\Core\Database\Query\QueryHelper::stripLogicalOperatorPrefix() should be used on config.additionalWhere.

[1] https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/XmlSitemap/Index.html#xmlsitemapdataproviders

Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions #2

Updated by Rémy DANIEL over 4 years ago

  • Assignee set to Rémy DANIEL
Actions #3

Updated by Susanne Moog over 4 years ago

  • Tags set to CodingNight
Actions #4

Updated by Susanne Moog over 4 years ago

  • Target version set to next-patchlevel
Actions #5

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions #6

Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions #7

Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions #8

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61523

Actions #9

Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392

Actions #10

Updated by Rémy DANIEL over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61612

Actions #12

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61612

Actions #13

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61612

Actions #14

Updated by Tymoteusz Motylewski over 4 years ago

  • Status changed from Under Review to Resolved
Actions #15

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF