Bug #89041

GridDataService::generateDataArray missing pid in record data

Added by Frank Naegler 7 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
Start date:
2019-08-29
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

With #89008 the GridDataService changed and use the PID of a record in case the table is tt_content, but the records do not contain the PID.
this issue exists only in master, for v9 the problem was found before the merge happens.


Related issues

Related to TYPO3 Core - Task #89008: Migrate TYPO3/CMS/Workspace/* to TypeScript Closed 2019-08-23
Related to TYPO3 Core - Bug #89050: Missing icon if only content elements are staged for changes Closed 2019-08-30

Associated revisions

Revision 91004d40 (diff)
Added by Frank Naegler 7 months ago

[BUGFIX] Ensure pid is selected for records

The GridDataService is using the PID of a record. This patch
ensure that the PID is selected while generating the data array.

Resolves: #89041
Related: #89008
Releases: master
Change-Id: I5d134611fd81d94c5618396660b280dd503cc6c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61574
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Richard Haeser <>
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Richard Haeser <>

Revision 46c91903 (diff)
Added by Andreas Fernandez 7 months ago

[BUGFIX] Select pid for both sides of a staged record

`WorkspaceService::selectAllVersionsFromPages()` must select the pid of
both sides of a staged record to be able to build a proper language
icon.

Resolves: #89050
Related: #89041
Releases: master
Change-Id: I18a5e59598cfc189da0b79c4f6ae01540d88fe0f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61584
Tested-by: Frank Naegler <>
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Frank Naegler <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Frank Naegler 7 months ago

  • Related to Task #89008: Migrate TYPO3/CMS/Workspace/* to TypeScript added

#2 Updated by Gerrit Code Review 7 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61574

#3 Updated by Frank Naegler 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Andreas Fernandez 7 months ago

  • Related to Bug #89050: Missing icon if only content elements are staged for changes added

#5 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF