Task #89008
Epic #82577: Migrate all JavaScript to TypeScript
Migrate TYPO3/CMS/Workspace/* to TypeScript
100%
Related issues
Associated revisions
[TASK] Migrate EXT:workspaces to TypeScript
Resolves: #89008
Releases: master
Change-Id: I6d967dd14986fc70631718da88427bff181bf4a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61530
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
[BUGFIX] Ensure pid is selected for records
The GridDataService is using the PID of a record. This patch
ensure that the PID is selected while generating the data array.
Resolves: #89041
Related: #89008
Releases: master
Change-Id: I5d134611fd81d94c5618396660b280dd503cc6c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61574
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
[BUGFIX] Prevent PHP type error and stale language cache
In EXT:workspaces, as consequence of changes in #89008,
PHP is raising an error if $pageId cannot be resolved to an
integer value as required by method signature.
Additionally, an internally cached array is built based on a
dynamic value but the internal cache is not keyed by this
value or flushed when the value changes.
This patch:
- Casts an unresolved page ID to integer zero.
- Removes the internal cache of languages since the array
now depends entirely on a unique input value, $pageId.
Resolves: #89692
Related: #89008
Releases: master
Change-Id: I3d74b4c7575375aae23a7e2473100104c4700966
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62308
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <look@susi.dev>
History
#1
Updated by Gerrit Code Review 4 months ago
- Status changed from In Progress to Under Review
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61530
#2
Updated by Gerrit Code Review 3 months ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61530
#3
Updated by Gerrit Code Review 3 months ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61530
#4
Updated by Gerrit Code Review 3 months ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61530
#5
Updated by Andreas Fernandez 3 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 792dae2e94003817584cc92402c839c65020525b.
#6
Updated by Frank Naegler 3 months ago
- Related to Bug #89041: GridDataService::generateDataArray missing pid in record data added
#7
Updated by Gerrit Code Review 26 days ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62308
#8
Updated by Gerrit Code Review 26 days ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62308
#9
Updated by Claus Due 23 days ago
- Precedes Bug #89692: Followup #89008, PHP type errors and stale workspace page language cache added