Bug #89116

Selective writing of site config broken for nested structures

Added by Andreas Fernandez about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-09-09
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

In case nested structures (e.g. languages) change their order, the resulting configuration breaks with invalid values.


Related issues

Related to TYPO3 Core - Feature #86803: Possibility to import other yaml files into a yaml site configuration Closed 2018-10-30
Duplicated by TYPO3 Core - Bug #90159: Site config: language baseVariants get removed when saving from GUI Closed 2020-01-20

Associated revisions

Revision e3574986 (diff)
Added by Andreas Fernandez about 1 year ago

[BUGFIX] Fix configuration composition for nested structures

When a new site configuration gets written, removed values are
determined first and changed values are determined afterwards to keep
nested structures intact.

Resolves: #89116
Related: #86803
Releases: master
Change-Id: I6deae2a3f6eed121aa2753f2ba9a5cafa058a54d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61646
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Benni Mack <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Benni Mack <>

Revision 9c5f0333 (diff)
Added by Susanne Moog about 1 year ago

[BUGFIX] Allow selective saving in SiteConfiguration

YAML SiteConfiguration allows imports and custom configuration
that is not configurable via UI to be written directly into the
configuration files, however, when saving with the UI these
settings are overwritten and resolved. This change changes the
SiteConfiguration in a way, that only modified values are written
and imports are completely left as they are.

Resolves: #86803
Related: #89116
Releases: master, 9.5
Change-Id: I92ece4959d57f41535e6fc8c3c7c9d2894d7f920
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61603
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Andreas Fernandez about 1 year ago

  • Related to Feature #86803: Possibility to import other yaml files into a yaml site configuration added

#2 Updated by Gerrit Code Review about 1 year ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61646

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61646

#4 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61646

#5 Updated by Andreas Fernandez about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

#7 Updated by Jonas Eberle 6 months ago

  • Duplicated by Bug #90159: Site config: language baseVariants get removed when saving from GUI added

Also available in: Atom PDF