Bug #89213

Automatic slug generation for TCA "slug" ignores language fallbacks

Added by Christian Eßl 5 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Category:
Link Handling, Site Handling & Routing
Start date:
2019-09-20
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The following example scenario:

  • We have 3 languages: default, fr_FR, fr_CH.
  • fr_CH (swiss french) has a language fallback to fr_FR configured in the site configuration.
  • We have a page "Parent page" which is translated in "default" and "fr_FR".

If you now create a new sub page of "Parent page" and translate this page to "fr_CH", the slug will automatically create a slug which, for the parent page, uses the title in the default language, not for "fr_FR".
It looks like the slug generation tool currently does not respect the configured language fallbacks.


Related issues

Related to TYPO3 Core - Bug #88173: Rootline of non-translated subpage isn't built using translated slugs Closed 2019-04-18

Associated revisions

Revision e419daf3 (diff)
Added by Christian Eßl about 1 month ago

[BUGFIX] Respect fallback languages in slug generation for pages

When creating a new subpage of another page, the TCA type "slug" will
automatically generate a slug for the new page which uses the title
of the parent page. When translating the page, the slug will try to get
the correct language for the parent record (if possible). This check did
previously not respect possible fallback languages for the language of
the new record. (configured in the site configuration)

Resolves: #89213
Releases: master, 9.5
Change-Id: Id0e43aba805a7d2596e2468223517241e0151676
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766
Tested-by: TYPO3com <>
Tested-by: Markus Klein <>
Tested-by: Benni Mack <>
Reviewed-by: Markus Klein <>
Reviewed-by: Benni Mack <>

Revision 93b9f59e (diff)
Added by Christian Eßl about 1 month ago

[BUGFIX] Respect fallback languages in slug generation for pages

When creating a new subpage of another page, the TCA type "slug" will
automatically generate a slug for the new page which uses the title
of the parent page. When translating the page, the slug will try to get
the correct language for the parent record (if possible). This check did
previously not respect possible fallback languages for the language of
the new record. (configured in the site configuration)

Resolves: #89213
Releases: master, 9.5
Change-Id: Id0e43aba805a7d2596e2468223517241e0151676
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62899
Tested-by: TYPO3com <>
Tested-by: Sascha Rademacher <>
Tested-by: Susanne Moog <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Susanne Moog <>

History

#1 Updated by Christian Eßl 5 months ago

  • Category set to Link Handling, Site Handling & Routing

#2 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#3 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#4 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61767

#5 Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#6 Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#7 Updated by Gerrit Code Review 5 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#8 Updated by Christian Eßl 5 months ago

  • Assignee set to Christian Eßl

#9 Updated by Gerrit Code Review 5 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#10 Updated by Gerrit Code Review 5 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#11 Updated by Gerrit Code Review 5 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#12 Updated by Gerrit Code Review 5 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#13 Updated by Gerrit Code Review 5 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#14 Updated by Gerrit Code Review 5 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#15 Updated by Gerrit Code Review 5 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#16 Updated by Gerrit Code Review 5 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#17 Updated by Gerrit Code Review 5 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#18 Updated by Gerrit Code Review 4 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#19 Updated by Gerrit Code Review 4 months ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#20 Updated by Gerrit Code Review about 1 month ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#21 Updated by Gerrit Code Review about 1 month ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#22 Updated by Gerrit Code Review about 1 month ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#23 Updated by Gerrit Code Review about 1 month ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61766

#24 Updated by Markus Klein about 1 month ago

  • Related to Bug #88173: Rootline of non-translated subpage isn't built using translated slugs added

#25 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62899

#26 Updated by Christian Eßl about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#27 Updated by Gerrit Code Review about 1 month ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62899

#28 Updated by Christian Eßl about 1 month ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF