Project

General

Profile

Actions

Task #89303

closed

Make list of changes ($historyRecords) accessable

Added by Christoph Lehmann about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
DataHandler aka TCEmain
Start date:
2019-09-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The Datahandler has a variable named $historyRecords which is primarly used to create a history entry in the database. Its structure is like

Array
(
    [pages:109203] => Array
        (
            [oldRecord] => Array
                (
                    [categories] => 
                )

            [newRecord] => Array
                (
                    [categories] => 794
                )

        )
)

The variable is also useful in hooks like processDatamap_afterDatabaseOperations to get an easy view of what really changed.

Currently you have to

- use an early hook (preProcess) to get the actual record and store it in a cache
- use a late hook (afterDatabase) to the new record
- maybe more sql queries because of mm changes
- compare them

I would like to make $historyRecords public accessable to handle changes more easily.

Actions #1

Updated by Christoph Lehmann about 5 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61858

Actions #3

Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61858

Actions #4

Updated by Christoph Lehmann about 5 years ago

  • Description updated (diff)
Actions #5

Updated by Christoph Lehmann about 5 years ago

You can close the issue. Talked with Andreas about it and came to the conclusion to use the recordHistory.

Actions #6

Updated by Björn Jacob about 5 years ago

  • Status changed from Under Review to Closed

Closed as requested by the author.

Actions #7

Updated by Gerrit Code Review about 5 years ago

  • Status changed from Closed to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61858

Actions #8

Updated by Gerrit Code Review about 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61858

Actions #9

Updated by Gerrit Code Review about 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61858

Actions #10

Updated by Gerrit Code Review about 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61858

Actions #11

Updated by Gerrit Code Review about 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61858

Actions #12

Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61831

Actions #13

Updated by Christoph Lehmann about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #14

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF