Project

General

Profile

Actions

Bug #89531

closed

Regression: "Show" in context menu for pages always shows root page on databases not casting return types

Added by Patrick Broens about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Start date:
2019-10-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
no-brainer
Is Regression:
Yes
Sprint Focus:

Description

Since #56351 in V9.5.10 the "Show" link in context menus for pages is not opening the selected page when a database or database driver is used returning only strings, like the default settings of the "pdo_mysql" driver.

The following line from the method getPreviewPid in Web/typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php will always return the second value, since $this->record['sys_language_uid'] is not type casted to an integer before doing the strict comparison, which means always false:

return (int)$this->record['sys_language_uid'] === 0 ? (int)$this->record['uid'] : (int)$this->record['l10n_parent'];

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #56351: view page in another language than default language from Backend is incorrectClosed2014-02-26

Actions
Actions #1

Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62153

Actions #2

Updated by Gerrit Code Review about 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62153

Actions #3

Updated by Oliver Bartsch about 5 years ago

  • Related to Bug #56351: view page in another language than default language from Backend is incorrect added
Actions #4

Updated by Gerrit Code Review about 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62134

Actions #5

Updated by Oliver Bartsch about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF