Bug #89619

LinkBrowser requests incorrect URL when switching tabs during loading process

Added by Dennis Prinse over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-11-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The LinkBrowser in TYPO3 v8 and v9 requests an incorrect URL when switching tabs. The problem occurs when a user switches from one to another tab if the page/resources haven't been loaded completely.

In AbstractLinkBrowserController->buildMenuArray(), the href is set to # and the onclick="jumpToUrl(url)" argument will be used to navigate to another tab in the LinkBrowser.

This behaviour has changed in TYPO3 10 (master). The jumpToUrl function has been marked deprecated (see issue #89033) and the href is set to the url instead of a #. Switching tabs is no longer dependent of JavaScript in the changed implementation.

I've managed to reproduce this bug on several installations and TYPO3 versions of our customers and on my local ddev TYPO3 installation.

Steps to reproduce the problem:
  • Open the inspector and throttle your connection. It's not necessary, but comes in handy if you have a fast connection or if your website contains just a few files in your filelist/filemount
  • Add a new content element, for example the Regular Text element
  • Use the Link Browser for the header link or inside the RTE to insert a link to the element
  • Try switching tabs before the page is completely loaded or during loading process
  • You should now hopefully get an error in your Link Browser

It's quite a difficult problem to reproduce. I couldn't always get to reproduce the error.

What I tried on some of the installations is applying the little block of code that has changed in issue #89033. TYPO3 v8 compared to v9 and v10 has minor differences according to building the url, but with some modifications I could get it to work with that version too. Applying this code solved the problem in our case.


Related issues

Related to TYPO3 Core - Task #89033: Deprecate jumpToUrlClosed2019-08-28

Actions
#1

Updated by Dennis Prinse over 1 year ago

  • Subject changed from LinkBrowser request incorrect URL when switching tabs during loading process to LinkBrowser requests incorrect URL when switching tabs during loading process
#2

Updated by Richard Haeser over 1 year ago

  • TYPO3 Version changed from 8 to 9
#3

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62344

#4

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62356

#5

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62344

#6

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62356

#7

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62344

#8

Updated by Anonymous about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed
#10

Updated by Gerrit Code Review about 1 year ago

  • Status changed from Closed to Under Review

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62356

#11

Updated by Markus Klein 12 months ago

#12

Updated by Anonymous 12 months ago

  • Status changed from Under Review to Resolved
#13

Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF