Bug #89679

postProcContent hooks in felogin override each other

Added by Christian Eßl 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
felogin
Target version:
-
Start date:
2019-11-14
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

felogin implements the following hook to do "post processing" (like substitung markers):

$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['postProcContent']

If multiple classes are present, that use this hooks, the content will always be overriden. - Only the changes in the last executed hook are visible.


Related issues

Duplicated by TYPO3 Core - Task #89930: [BUGFIX] Only last postProcContent-hook is applied Closed 2019-12-12

Associated revisions

Revision 525cde7e (diff)
Added by Christian Eßl about 1 month ago

[BUGFIX] Correctly pass arguments to ext:felogin "postProcContent" hook

If multiple functions are present, that call the hook
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['postProcContent'],
only the changes of the last executed hook would be present, as each
hook in the loop will be executed with the initial value of $content, .
not the last written $content.
To fix this behaviour, the $_params must be initialized inside the loop.

Resolves: #89679
Releases: master, 9.5
Change-Id: Ie54c45d9126acd01637c19c289c9942d0452fdae
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62325
Tested-by: TYPO3com <>
Tested-by: Jörg Bösche <>
Tested-by: Frank Nägler <>
Reviewed-by: Guido Schmechel <>
Reviewed-by: Tobi Kretschmann <>
Reviewed-by: Steffen Frese <>
Reviewed-by: Felix P. <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Henning Liebe <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Frank Nägler <>

Revision 838a23e6 (diff)
Added by Christian Eßl about 1 month ago

[BUGFIX] Correctly pass arguments to ext:felogin "postProcContent" hook

If multiple functions are present, that call the hook
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['postProcContent'],
only the changes of the last executed hook would be present, as each
hook in the loop will be executed with the initial value of $content, .
not the last written $content.
To fix this behaviour, the $_params must be initialized inside the loop.

Resolves: #89679
Releases: master, 9.5
Change-Id: Ie54c45d9126acd01637c19c289c9942d0452fdae
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62941
Tested-by: TYPO3com <>
Tested-by: Frank Nägler <>
Reviewed-by: Frank Nägler <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62325

#2 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62941

#3 Updated by Christian Eßl about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Susanne Moog 25 days ago

  • Duplicated by Task #89930: [BUGFIX] Only last postProcContent-hook is applied added

Also available in: Atom PDF