Bug #89771

rel="noreferer" should be set for all new windows, not just _blank

Added by Jonas Eberle about 2 months ago. Updated 9 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
-
Start date:
2019-11-25
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
noopener noreferrer target links
Complexity:
Is Regression:
Sprint Focus:

Description

The condition for adding rel="noreferer" should be:

"target" NOT IN (_self _parent _top) instead of the current check target=_blank.

A target="myname" would give the same attack surface as target="_blank". (I just verified with Firefox)


Related issues

Related to TYPO3 Core - Bug #89757: Fix noopener noreferrer issue Closed 2019-11-23
Related to TYPO3 Core - Bug #89044: Links in the TYPO3 backend and install tool should have set rel="noopener noreferrer" for external links Closed 2019-08-29
Related to TYPO3 Core - Feature #78488: Add rel="noopener noreferrer" to links when target is set to _blank Closed 2016-10-28

Associated revisions

Revision 0e5c7755 (diff)
Added by Jonas Eberle 9 days ago

[BUGFIX] Add rel="noreferrer" to all external links opened in new window

This patch defines "opening in a new window" as links having an attribute
`target` that is not either empty, `_self`, `_top` or `_parent`.

Resolves: #89771
Relates: #89757
Relates: #89044
Relates: #78488
Releases: master
Change-Id: I23f775f728b9ddfb25acd306b653cbfbb6eeba51
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62430
Tested-by: TYPO3com <>
Tested-by: Jörg Bösche <>
Tested-by: Susanne Moog <>
Tested-by: Benni Mack <>
Reviewed-by: Tobi Kretschmann <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Jörg Bösche <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Jonas Eberle about 2 months ago

  • Related to Bug #89757: Fix noopener noreferrer issue added

#2 Updated by Jonas Eberle about 2 months ago

  • Related to Bug #89044: Links in the TYPO3 backend and install tool should have set rel="noopener noreferrer" for external links added

#3 Updated by Jonas Eberle about 2 months ago

  • Related to Feature #78488: Add rel="noopener noreferrer" to links when target is set to _blank added

#4 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62430

#5 Updated by Gerrit Code Review about 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62430

#6 Updated by Gerrit Code Review about 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62430

#7 Updated by Gerrit Code Review about 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62430

#8 Updated by Gerrit Code Review 9 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62430

#9 Updated by Anonymous 9 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF