Bug #89774: Incomplete task configuration breaks the backend module - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #89774

closed

Incomplete task configuration breaks the backend module

Added by Jan Delius almost 5 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

scheduler

Target version:

Start date:

2019-11-26

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If you create a new task, which should execute a console command, you have to save it before you can fill in the necessary arguments. If you now close the form, you can no longer call the Scheduler Backend module. The Symfony class "Input" throws a Symfony\Component\Console\Exception\RuntimeException because not all necessary arguments are set.

Steps to reproduce:
1. Click the "Add task" button inside the scheduler module
2. Select class "Execute console commands", select either type single or specify a frequency.
3. Select a "Schedulable Command" that has a required argument
4. Click "Save and close" (or save first and close the form after saving)
5. Scheduler module is broken now :(

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62756

Actions

Copy link

Updated by Tymoteusz Motylewski almost 5 years ago

I have troubles reproducing it.
can you point me to the example of ""Schedulable Command" that has a required argument?
thanks

Actions

Copy link

Updated by Joerg Boesche almost 5 years ago

Tymoteusz Motylewski wrote:

I have troubles reproducing it.
can you point me to the example of ""Schedulable Command" that has a required argument?
thanks

Hey Tymoteusz, here is an example to reproduce.

Test scenario before the patch
-------------------------------------------------------
- Add new task of type "Execute console commands (scheduler)"
- Add frequency of "*/30 * * * *"
- Select "redirects:checkintegrity: Check integrity of redirects", for example
- Save the task
- Open the class "\TYPO3\CMS\Redirects\Command\CheckIntegrityCommand" and change the InputArgument from optional to required.
- Run the previous created scheduler tasks
- An T3 exception is thrown

Test scenario after the patch (with added task before)
-------------------------------------------------------
- Run the scheduler task again
- A red notification with the text "
Execution of task "Execute console commands (scheduler)" failed with the following message: Not enough arguments (missing: "site")." is visible and no T3 exception was thrown.

Actions

Copy link

Updated by Gerrit Code Review almost 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62894

Actions

Copy link