Bug #89810
Language Packs: Error if mirror download times out
100%
Description
If the internet connection is pretty bad, downloading language packs isn't possible if downloading the mirrors fails due to a timeout with the following exception:
gzdecode() expects parameter 1 to be string, boolean given
Associated revisions
[BUGFIX] Use RequestFactory for downloading mirrors and check response properly
The LanguagePackService now uses the RequestFactory to download the
mirrors.xml.gz file, since it throws proper exceptions on failures.
In case of e.g. a timeout, the thrown exception is properly caught and
the designed fallback kicks in.
Resolves: #89810
Releases: master, 9.5
Change-Id: Ie4e8bcf02c33eb18e58f505f1a791c1233d6f593
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
[BUGFIX] Use RequestFactory for downloading mirrors and check response properly
The LanguagePackService now uses the RequestFactory to download the
mirrors.xml.gz file, since it throws proper exceptions on failures.
In case of e.g. a timeout, the thrown exception is properly caught and
the designed fallback kicks in.
Resolves: #89810
Releases: master, 9.5
Change-Id: Ie4e8bcf02c33eb18e58f505f1a791c1233d6f593
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62462
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
History
#1
Updated by Gerrit Code Review 9 days ago
Updated by - Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496
#2
Updated by Gerrit Code Review 6 days ago
Patch set 1 for branch master of project Teams/Security/TYPO3v4-Core has been pushed to the review server.
It is available at https://review.typo3.org/c/Teams/Security/TYPO3v4-Core/+/62505
#3
Updated by Gerrit Code Review 6 days ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496
#4
Updated by Gerrit Code Review 6 days ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496
#5
Updated by Gerrit Code Review 4 days ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496
#6
Updated by Gerrit Code Review 4 days ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496
#7
Updated by Gerrit Code Review 2 days ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62462
#8
Updated by Andreas Fernandez 2 days ago
Updated by - Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d93d742f912b6f7b41108c60dff2910160eb4c38.
#9
Updated by Gerrit Code Review 2 days ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62462
#10
Updated by Richard Haeser 2 days ago
Updated by - Status changed from Under Review to Resolved
Applied in changeset 2c48f62769f24edf060e577d55c927f09e094ba1.