Task #90002

Apply rector set php71

Added by Alexander Schnitzler about 1 month ago. Updated 26 days ago.

Status:
Resolved
Priority:
Should have
Category:
-
Target version:
-
Start date:
2019-12-20
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision 2db847fb (diff)
Added by Alexander Schnitzler 26 days ago

[TASK] Apply rector set php71

php bin/rector process

A couple of rectors have been disabled due to different reasons:

- Rector\Php71\Rector\FuncCall\CountOnNullRector
This rector has been disabled as it creates rather long and
complex structures to avoid calling count on null.

This rector will be enabled as soon as TYPO3 uses at least
PHP 7.3 which introduces a "is_countable" method.

- Rector\Php71\Rector\Assign\AssignArrayToStringRector
This rector has been disabled as it does not work properly.
The default types of parameters have been changed although
their types could properly be inferred by a doc block or
by value assignments.

- Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector
This rector has been disabled as it does not work properly.
A bug report is filed and to be found here:
https://github.com/rectorphp/rector/issues/2454

- Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector
This rector has been disabled as it does not work properly.
It removed arguments in tests, especially when using
prophecies.

Releases: master
Resolves: #90002
Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751

#2 Updated by Anonymous 26 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF