Bug #90060
closedExtending Site configuration TCA with any select-type field does not handle selected values
0%
Description
Problem:
Extending the pseudo-TCA configuration for "Sites" module to add a field of type "select" with multiple options allowed will not render the field with selected values.
Cause:
An explicit check for saved values NOT being an array is implemented, causing any array-like value to be completely ignored
Reasoning:
Given that:
- Select-type fields with multiple possible options are possible
- Such values, when saved to site configuration, are possible to store
- The lack of "selected" status on all options causes second and subsequent saving of form to null such fields' values
I conclude that:
- We should not be intentionally ignoring array-like values
Solution:
- Removing the `!is_array` check makes multi-option select fields work correctly
- This in turn means the entire loop can be replaced with an array union
Updated by Gerrit Code Review almost 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62825
Updated by Gerrit Code Review almost 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62825
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62825
Updated by Gerrit Code Review about 3 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62825
Updated by Christian Kuhn almost 3 years ago
- Status changed from Under Review to Rejected