Bug #90171

LinkService does not know how to handle urls without protocol

Added by Riny van Tiggelen 9 months ago. Updated 8 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-01-22
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Urls without protocol, for example:

//google.com

are not recognized by the LinkService which results in an:
not implemented type unknown

error within the backend.

Although you can still edit the URL, the error shown is confusing for editors.

For now, it's possible to hook into the LinkService but this might be something that should be covered by core.

Associated revisions

Revision be494aa8 (diff)
Added by Georg Ringer 8 months ago

[BUGFIX] LinkService should identify urls starting with //

Urls starting with `//` should have a proper fallback to
avoid warnings e.g. in InputLinkElement that this type of url
is unknown.

Resolves: #90171
Releases: master, 9.5
Change-Id: Ic3910f98c3993fb5db523ba1b360eabb49bf0696
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Daniel Goerz <>
Reviewed-by: Benni Mack <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543

#2 Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543

#3 Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543

#4 Updated by Gerrit Code Review 8 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543

#5 Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63576

#6 Updated by Georg Ringer 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review 8 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63576

Also available in: Atom PDF