Project

General

Profile

Actions

Bug #90202

closed

Link Browser use wrong default title text

Added by Michael Binder over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2020-01-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
Link Browser, ckeditor
Complexity:
Is Regression:
Sprint Focus:

Description

The Link Browser used the last Titletext of an element and not the given default value.

Given is the following yaml config:

classesAnchor:
  internalLink:
    class: 'internal-link'
    type: 'page'
    titleText: 'Expected default title text'
  internalLinkNewWindow:
    class: 'internal-link-new-window'
    type: 'page'
    target: '_blank'
    titleText: 'Displayed title text'

buttons:
  link:
    page:
      properties:
        class:
          default: internal-link
    properties:
      class:
        allowedClasses: 'internal-link, internal-link-new-window'

I expected as default title text 'Expected default title text' of the selected default class 'Internal Link', but the last title text ('Displayed title text') is displayed (see screenshot).

This happens in TYPO3 10.3 and also in TYPO3 9.

Possible solutions:
the default value is directly overwritten again in '\TYPO3\CMS\RteCKEditor\Controller\BrowseLinksController::renderLinkAttributeFields' this part should be modified.

if ($conf['titleText']) {
   $this->classesAnchorClassTitle[$conf['class']] = ($this->classesAnchorDefaultTitle[$conf['type']] = $this->contentLanguageService->sL(trim($conf['titleText'])));
}


Files

LinkBrowser.png (68.5 KB) LinkBrowser.png Link Browser with wrong default title text Michael Binder, 2020-01-25 16:12
Actions #1

Updated by Riccardo De Contardi over 4 years ago

I think that these are related: #83754 #88710

Actions #2

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63034

Actions #3

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63883

Actions #4

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63883

Actions #5

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63866

Actions #6

Updated by Daniel Goerz about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF