Bug #90448

Admin panel rendering "Tree display" doesn't show icons and guidelines

Added by Tymoteusz Motylewski about 1 month ago. Updated 28 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
AdminPanel
Target version:
-
Start date:
2020-02-20
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When debugging rendering times in the admin panel, and the "Tree display" setting is enabled, the view should show icons and guidelines showing which line is a children of which parent.

Seems that some icon related markup is in html, but its not styled properly.

Screenshot from 2020-02-20 10-32-14.png View (87.4 KB) Tymoteusz Motylewski, 2020-02-20 10:32

Screenshot from 2020-02-21 20-32-05.png View (14.4 KB) Tymoteusz Motylewski, 2020-02-21 20:32

Bildschirmfoto 2020-02-26 um 07.40.53.png View (18.7 KB) Christian Eßl, 2020-02-26 07:41

Screenshot from 2020-03-03 12-27-13.png View (84.7 KB) Tymoteusz Motylewski, 2020-03-03 12:31

Associated revisions

Revision dc9e8bfe (diff)
Added by Tymoteusz Motylewski 28 days ago

[BUGFIX] Show guidelines in Adminpanel rendering tree view

The tree guidelines are now properly shown in the TS Tree view
in AdminPanel.
Also not used FontAwesome is removed from AdminPanel

Resolves: #90448
Releases: 9.5, master
Change-Id: I065a65a9b7de049d2c5e325f0ae15d28a2853303
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63355
Tested-by: Christian Eßl <>
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Reviewed-by: Christian Eßl <>
Reviewed-by: Georg Ringer <>

Revision c047024b (diff)
Added by Tymoteusz Motylewski 28 days ago

[BUGFIX] Show guidelines in Adminpanel rendering tree view

The tree guidelines are now properly shown in the TS Tree view
in AdminPanel.
Also not used FontAwesome is removed from AdminPanel

Resolves: #90448
Releases: 9.5, master
Change-Id: I065a65a9b7de049d2c5e325f0ae15d28a2853303
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63541
Tested-by: Tymoteusz Motylewski <>
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Daniel Goerz about 1 month ago

  • Description updated (diff)

#2 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63355

#3 Updated by Tymoteusz Motylewski about 1 month ago

Current status - lines are shown, but icons needs to be fixed

#4 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63355

#5 Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63355

#6 Updated by Christian Eßl about 1 month ago

Icons still look weird.
Second text line lies over the dotted line (needs an indent)

#7 Updated by Gerrit Code Review 28 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63355

#8 Updated by Tymoteusz Motylewski 28 days ago

Result after the last patchset:

#9 Updated by Tymoteusz Motylewski 28 days ago

TS I've used for testing:

page >
page = PAGE
page.10 = TEXT
page.10.value = Click
page.10.typelink.parameter = 16
page {
  20 = COA
  20 {
    2010 = TEXT
    2010.value = something
    2020 = COA
    2020 {
      202010 = TEXT
      202010.value = third level

      202020 = COA
      202020 {
        10 = TEXT
        10.value = oiwjdiowjei
      }
      202030 = TEXT
      202030.value = third level

      202040 = COA
      202040 {
        10 = TEXT
        10.value = oiwjdiowjei
      }
    }
    stdWrap = oiwehfwhfohi | iowhiohweof
    stdWrap.cObject = TEXT
    stdWrap.cObject.value = stdwrap
  }
}

#10 Updated by Tymoteusz Motylewski 28 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Gerrit Code Review 28 days ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63541

#12 Updated by Tymoteusz Motylewski 28 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF