Bug #90960

Arguments not passed to Header and Footer partials in Fluid-based replacement for PageLayoutView

Added by Georg Tiefenbrunn 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2020-04-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

#90348 introduced Fluid-based replacement for PageLayoutView.

According to https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/10.3/Feature-90348-NewFluid-basedReplacementForPageLayoutView.html {item} (and some other variables) should be available in custom header/footer/preview templates.

Currently access to {item} (and the other variables) is only available in custom preview templates (no access in custom header/footer templates).

Preview is rendered by https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record/Preview.html and {item} is passed by arguments="{_all}":

<f:render partial="PageLayout/Record/{item.record.CType}/Preview" arguments="{_all}" optional="1">

Header and Footer are rendered by https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html without arguments:

 4 <f:render partial="PageLayout/Record/{item.record.CType}/Header" optional="1">
13 <f:render partial="PageLayout/Record/{item.record.CType}/Footer" optional="1">
#1

Updated by Georg Ringer 8 months ago

  • Status changed from New to Accepted
  • Target version set to 10 LTS
#2

Updated by Georg Ringer 8 months ago

  • Status changed from Accepted to Needs Feedback

can you check out latest master, IMO this has been fixed. thanks

#3

Updated by Georg Tiefenbrunn 8 months ago

can you check out latest master, IMO this has been fixed. thanks

Last commit to https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Resources/Private/Partials/PageLayout/Record.html was on 2020-04-05 22:31 - not fixed :(

Line 4 <f:render partial="PageLayout/Record/{item.record.CType}/Header" optional="1">

Line 13 <f:render partial="PageLayout/Record/{item.record.CType}/Footer" optional="1">

TS setup:

module.tx_backend.view.templateRootPaths.100 = EXT:myext/Resources/Private/Backend/Templates/
module.tx_backend.view.partialRootPaths.100 = EXT:myext/Resources/Private/Backend/Partials/

File EXT:myext/Resources/Private/Backend/Partials/PageLayout/Record/Html/Footer.html

<f:debug>{item}</f:debug>

Output with current master:

Extbase Variable Dump
NULL

Output after changing line 13 (see above) to <f:render partial="PageLayout/Record/{item.record.CType}/Footer" arguments="{_all}" optional="1"> (added arguments="{_all}")

Extbase Variable Dump
TYPO3\CMS\Backend\View\BackendLayout\Grid\GridColumnItem
...

The "global" footer (PageLayout/Record/Footer) and header (PageLayout/Record/Header) partials are OK (arguments="{_all}").
The optional element specific partials (PageLayout/Record/{item.record.CType}/Footer and PageLayout/Record/{item.record.CType}/Header) have no arguments/data.

#4

Updated by Gerrit Code Review 8 months ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64103

#5

Updated by Christian Eßl 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF