Task #90348

PageLayoutView and BackendLayout should be refactored to separate rendering, processing and fetching of content

Added by Claus Due 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2020-02-10
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The giant class PageLayoutView should be refactored to create smaller and more managable components with dedicated responsibilities:

  • Seperate content fetching from markup output
  • Seperate drawing from content processing

Furthermore it makes sense to use the BackendLayout concept as a binding class, making a PageLayoutView instance require a BackendLayout in order to render, and having BackendLayout provide the delegates that will fetch, process and render content elements.


Related issues

Related to TYPO3 Core - Bug #90479: New fluidbased PageLayoutView throws error, if backendLayout can no longer be resolved Closed 2020-02-21
Related to TYPO3 Core - Bug #90608: PageLayoutView doesn't take `tables_modify` into account Closed 2020-03-01
Related to TYPO3 Core - Bug #90605: fluidbased PageLayoutView doesn't take `tables_modify` into account Closed 2020-03-01
Related to TYPO3 Core - Bug #90603: Check in fluidbased PageLayoutView for language existence Closed 2020-02-29
Related to TYPO3 Core - Bug #90559: After Update from 10.2.2 to 10.3.0 translation button in alternative language column is missing Closed 2020-02-27
Related to TYPO3 Core - Bug #90617: Page Module: No content elements displayed with mod.web_layout.defLangBinding Resolved 2020-03-02
Related to TYPO3 Core - Task #90943: Warning in unit tests due to BackendLayout::parseConfigurationStringAndSetConfigurationArray being removed Closed 2020-04-04

Associated revisions

Revision a7372ce6 (diff)
Added by Claus Due 8 months ago

[FEATURE] Fluid-based replacement for PageLayoutView

Provides a completely rewritten alternative to PageLayoutView
based on Fluid, and deprecates the old PageLayoutView. Adds
a feature flag TYPO3_CONF_VARS.SYS.features.fluidBasedPageModule
which can be used to switch back to the deprecated
PageLayoutView for installations which require this. The feature
flag is enabled by default in all new installations.

See included feature RST for more detailed information.

Releases: master
Resolves: #90348
Change-Id: Icf10b12130c238c63db74a608c67942ba912d307
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186
Tested-by: Kevin Appelt <>
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Manuel Selbach <>
Tested-by: Claus Due <>
Reviewed-by: Kevin Appelt <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Manuel Selbach <>
Reviewed-by: Claus Due <>

Revision 3a65496e (diff)
Added by Anja Leichsenring 7 months ago

[TASK] Remove warning from BackendLayout UnitTest after method removal

During refactoring of the class a method was removed, that was still
mentioned in a mock creation. This raised a warning in unit test runs.
Removing the mentioning (and the mock alongside with it) returns
the tests to green.

Resolves: #90943
Related: #90348
Related: #90839
Releases: master
Change-Id: I558d0bcd31942aac6241c819c8bf011dba23fe2c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64067
Reviewed-by: Claus Due <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Guido Schmechel <>
Reviewed-by: Alexander Schnitzler <>
Reviewed-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Tested-by: Alexander Schnitzler <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#2 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#3 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#4 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#5 Updated by Gerrit Code Review 8 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#6 Updated by Gerrit Code Review 8 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#7 Updated by Gerrit Code Review 8 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#8 Updated by Gerrit Code Review 8 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#9 Updated by Gerrit Code Review 8 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#10 Updated by Gerrit Code Review 8 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#11 Updated by Gerrit Code Review 8 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#12 Updated by Gerrit Code Review 8 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#13 Updated by Gerrit Code Review 8 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#14 Updated by Gerrit Code Review 8 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#15 Updated by Gerrit Code Review 8 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#16 Updated by Gerrit Code Review 8 months ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#17 Updated by Gerrit Code Review 8 months ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#18 Updated by Gerrit Code Review 8 months ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#19 Updated by Gerrit Code Review 8 months ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#20 Updated by Gerrit Code Review 8 months ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#21 Updated by Gerrit Code Review 8 months ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#22 Updated by Gerrit Code Review 8 months ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#23 Updated by Gerrit Code Review 8 months ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#24 Updated by Gerrit Code Review 8 months ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#25 Updated by Gerrit Code Review 8 months ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#26 Updated by Gerrit Code Review 8 months ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#27 Updated by Gerrit Code Review 8 months ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#28 Updated by Gerrit Code Review 8 months ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#29 Updated by Gerrit Code Review 8 months ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#30 Updated by Gerrit Code Review 8 months ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#31 Updated by Gerrit Code Review 8 months ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#32 Updated by Gerrit Code Review 8 months ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#33 Updated by Gerrit Code Review 8 months ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#34 Updated by Gerrit Code Review 8 months ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#35 Updated by Gerrit Code Review 8 months ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#36 Updated by Gerrit Code Review 8 months ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#37 Updated by Gerrit Code Review 8 months ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#38 Updated by Gerrit Code Review 8 months ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#39 Updated by Gerrit Code Review 8 months ago

Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#40 Updated by Gerrit Code Review 8 months ago

Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#41 Updated by Gerrit Code Review 8 months ago

Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#42 Updated by Gerrit Code Review 8 months ago

Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#43 Updated by Gerrit Code Review 8 months ago

Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#44 Updated by Gerrit Code Review 8 months ago

Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#45 Updated by Gerrit Code Review 8 months ago

Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#46 Updated by Gerrit Code Review 8 months ago

Patch set 46 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#47 Updated by Gerrit Code Review 8 months ago

Patch set 47 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#48 Updated by Gerrit Code Review 8 months ago

Patch set 48 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#49 Updated by Gerrit Code Review 8 months ago

Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186

#50 Updated by Anonymous 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#51 Updated by Christian Eßl 8 months ago

  • Related to Bug #90479: New fluidbased PageLayoutView throws error, if backendLayout can no longer be resolved added

#52 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

#53 Updated by Daniel Goerz 8 months ago

  • Related to Bug #90608: PageLayoutView doesn't take `tables_modify` into account added

#54 Updated by Daniel Goerz 8 months ago

  • Related to Bug #90605: fluidbased PageLayoutView doesn't take `tables_modify` into account added

#55 Updated by Daniel Goerz 8 months ago

  • Related to Bug #90603: Check in fluidbased PageLayoutView for language existence added

#56 Updated by Daniel Goerz 8 months ago

  • Related to Bug #90559: After Update from 10.2.2 to 10.3.0 translation button in alternative language column is missing added

#57 Updated by Daniel Goerz 8 months ago

  • Related to Bug #90617: Page Module: No content elements displayed with mod.web_layout.defLangBinding added

#58 Updated by Anja Leichsenring 7 months ago

  • Related to Task #90943: Warning in unit tests due to BackendLayout::parseConfigurationStringAndSetConfigurationArray being removed added

Also available in: Atom PDF