Task #91132

Epic #87417: Integrate proper Content Security Policy (CSP) handling

Task #87418: Refactor and remove usage of inline scripts in backend

Reduce inline JavaScript in ext:setup

Added by Oliver Hader 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Security
Target version:
-
Start date:
2020-04-19
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision c87e8e6d (diff)
Added by Oliver Hader about 1 month ago

[TASK] Reduce inline JavaScript in ext:setup

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings.

  • moves inline JavaScript for avatar handling to new SetupModule
  • avoids using configuration options `onClick`, `onClickLabels`
    and `confirmData.jsCodeAfterOk` which contain inline JavaScript
  • introduces configuration options `conformationData.eventName`
    and `clickData.eventName` to substitute mentioned deprecations
  • adds PSR-14 `AddJavaScriptModulesEvent` which allows to apply
    custom RequireJS modules to handle mentioned new custom events

Resolves: #91132
Releases: master, 10.4
Change-Id: Ia68d0c473db862e0381671604347bd15ec89be35
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

Revision b5f34156 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Reduce inline JavaScript in ext:setup

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings.

  • moves inline JavaScript for avatar handling to new SetupModule
  • avoids using configuration options `onClick`, `onClickLabels`
    and `confirmData.jsCodeAfterOk` which contain inline JavaScript
  • introduces configuration options `conformationData.eventName`
    and `clickData.eventName` to substitute mentioned deprecations
  • adds PSR-14 `AddJavaScriptModulesEvent` which allows to apply
    custom RequireJS modules to handle mentioned new custom events

Resolves: #91132
Releases: master, 10.4
Change-Id: Ia68d0c473db862e0381671604347bd15ec89be35
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64627
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#2 Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#3 Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#4 Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#5 Updated by Gerrit Code Review 2 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#6 Updated by Gerrit Code Review 2 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#7 Updated by Gerrit Code Review about 2 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#8 Updated by Gerrit Code Review about 2 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#9 Updated by Gerrit Code Review about 1 month ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64225

#10 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64627

#11 Updated by Oliver Hader about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF