Bug #91357
closed
Typolink strips #
100%
Description
The following commit introduced a bug with typolinks and fragments
https://github.com/TYPO3-CMS/core/commit/9192143d84da53877f22dea1cb553eef1d9b7f6e
In particular the following change:
Steps to reproduce:
FLUID
<f:link.typolink parameter="t3://page?uid=105#work-life-balance">FOO</f:link.typolink>
Expected output:
<a href="/test-page#work-life-balance">FOO</a>
Actual output:
<a href="/test-page">FOO</a>
PS:
If someone could advise me how I can do a "git bisect" with subtree split and composer setup - that would be awesome. Was quite hard to identify that commit.
PS 2:
"t3://page?uid=105#work-life-balance" is a quite 100% reasonable TYPO3 internal link. I do not understand, why it even reaches "LegacyLinkNotationConverter" - makes no sense to me. As the t3:// link gets resolved properly and then afterwards TYPO3 AGAIN tries to resolve the already resolved URL and this leads to this. This should be checked by someone with more core insights than me.
Updated by Georg Ringer almost 4 years ago
- Related to Bug #75213: Missing Anchors for PDFs added
Updated by Benni Mack almost 4 years ago
- Related to Bug #90916: Page type external URL, removes fragments from relativ URLs added
Updated by Gerrit Code Review almost 4 years ago
- Status changed from New to Under Review
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64411
Updated by Benjamin Franzke almost 4 years ago
PS:
If someone could advise me how I can do a "git bisect" with subtree split and composer setup - that would be awesome. Was quite hard to identify that commit.
You can avoid the subtree split by adding composer path repositories that point to system extensions within your github.com/TYPO3/TYPO3.CMS GIT-Checkout:
"repositories": [
{
"type": "path",
"url": "../TYPO3.CMS/typo3/sysext/*",
"options": {
"symlink": true
}
},
{ "type": "composer", "url": "https://composer.typo3.org/" }
],
"require": {
"typo3/cms-backend": "@dev",
"typo3/cms-core": "@dev",
"typo3/cms-extbase": "@dev",
"typo3/cms-extensionmanager": "@dev",
"typo3/cms-filelist": "@dev",
"typo3/cms-fluid": "@dev",
"typo3/cms-frontend": "@dev",
"typo3/cms-install": "@dev",
"typo3/cms-recordlist": "@dev"
}
You can then run git bisect in ../TYPO3.CMS/
Due to symlink: true you should only need composer dumpautoload and rm -rf var/cache between git bisect runs.
This is how we test composer mode when developing on git master.
Updated by Gerrit Code Review almost 4 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64411
Updated by Gerrit Code Review almost 4 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64368
Updated by Benni Mack almost 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 71440487f772fa8404fb5ac894914d487ff40c27.
Updated by Anonymous almost 4 years ago
Benjamin Franzke wrote:
PS:
If someone could advise me how I can do a "git bisect" with subtree split and composer setup - that would be awesome. Was quite hard to identify that commit.You can avoid the subtree split by adding composer path repositories that point to system extensions within your github.com/TYPO3/TYPO3.CMS GIT-Checkout:
[...]
You can then run
git bisectin../TYPO3.CMS/Due to
symlink: trueyou should only needcomposer dumpautoloadandrm -rf var/cachebetweengit bisectruns.This is how we test composer mode when developing on git master.
Thank you, Benjamin - indeed very helpful guide!