TYPO3 Core

Hi Oliver,

thanks for your feedback. So I test both proposals, but unfortunately none of them work.

Maybe the solution could be skipping the routes, which contains empty arguments to prevent the InvalidParameterException? In the example above we use the config to prevent side effects.

After some testing we found than also other Enhancers are affected. So we removed the config shown above and remove all empty parameters that are passed in the PageRouter::generateUri().

This will now fix the problems concerning the issue for all Enhancers without config.

class PageRouter extends PageRouterCore
{
    public function generateUri($route, array $parameters = [], string $fragment = '', string $type = ''): UriInterface
    {
        $removeEmptyParameter = function ($array) use (&$removeEmptyParameter) {
            $callback = function($value) {
                return !is_null($value) && $value !== '';
            };
            foreach ($array as &$value) {
                if (is_array($value)) {
                    $value = $removeEmptyParameter($value, $callback);
                }
            }
            return array_filter($array, $callback);
        };
        return parent::generateUri($route, $removeEmptyParameter($parameters), $fragment, $type);
    }
}

I've tested this again with this complete example

routeEnhancers:
  PageTypeSuffix:
    type: PageType
    default: '/'
    index: ''
    map:
      '/': 0
  Example:
    type: Extbase
    extension: Example
    plugin: Pi1
    defaultController: 'Category::list'
    routes:
      - routePath: '/category'
        _controller: 'Category::list'
      - routePath: '/category/{category_slug}'
        _controller: 'Category::list'
        _arguments:
          category_slug: category

   # important, no `defaults` section here for `category_slug`
   # there are two explicits routes now

generateUri('?id=1&tx_example_pi1[category]=1') → /page/category/name-of-category-1/
generateUri('?id=1&tx_example_pi1[controller]=Category') → /page/category/ (tx_example_pi1[controller] is required to give a hint for that particular enhancer configuration)

• basically this is the substitute for generateUri('?id=1&tx_example_pi1[category]='), which still fails - and this is expected since there must be a value, e.g. &tx_example_pi1[category]=0 would work)
• removing all blank ('') parameters per default might be breaking, since some other mapper, enhancer, ... could rely/handler exactly those cases already

Thus, I currently don't see the necessity to remove blank parameters. In case that would be implemented, I should be very specific for particular parameters (not for all).

Forgot to explain, why it fails. The PageType decorator adds a slash / to the end of each route path, which then looks like this:

/category/{tx_example_pi1_0}/

Since there must be a slash at the end, the parameter {tx_example_pi1_0} cannot be optional anymore. The only work-around would be to declare requirements.category_slug: '.*'. As a result, the generated URI would then be /category// (having two slashes at the end).