Task #92029
closedConfigurable target for cross-site typolinks
100%
Description
In \TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::build()
, the target of the link (if not explicitly defined) is evaluated as being external when a link is created from one Site to another. I have a situation with many (80+) web sites in the same instance, which are considered "internal" by the client. Thus the links should not be considered external. There's currently no configuration and no hook to change that behavior.
Is that considered as a feature or could it be considered a bug?
Updated by Georg Ringer almost 4 years ago
Hi Francois,
thanks for creating the issue!
What about providing a custom LinkBuilder in LocalConfiguration.php
with FE|typolinkBuilder|page => YourClass
, extend the PageLinkBuilder
and implement it there.
I don't think that another event/hook is needed. Would it be ok to close the issue?
Updated by Georg Ringer almost 4 years ago
- Status changed from New to Needs Feedback
Updated by Francois Suter almost 4 years ago
I hadn't thought about this possibility. I just felt that I might not be the only one having this need, but maybe I am ;-)
Also extending the PageLinkBuilder
is not very convenient, because it's still quite monolithic. So I still think that it could be a worthwhile feature. OTOH I'm conscious that if I don't work on it myself, it's probably never going to happen...
My current workaround is to apply a patch to it on the fly using Composer.
Updated by Gerrit Code Review over 2 years ago
- Status changed from Needs Feedback to Under Review
Patch set 38 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72999
Updated by Benni Mack over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4f7c4d1cc240071b38144e8f1d42cc62cdaedbe6.
Updated by Stefan Bürk over 2 years ago
- Related to Bug #97457: Use proper LinkFactory setup for newly added unit tests added