Project

General

Profile

Actions

Task #92029

closed

Configurable target for cross-site typolinks

Added by Francois Suter over 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Site Handling, Site Sets & Routing
Target version:
-
Start date:
2020-08-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.4
Tags:
Complexity:
Sprint Focus:

Description

In \TYPO3\CMS\Frontend\Typolink\PageLinkBuilder::build(), the target of the link (if not explicitly defined) is evaluated as being external when a link is created from one Site to another. I have a situation with many (80+) web sites in the same instance, which are considered "internal" by the client. Thus the links should not be considered external. There's currently no configuration and no hook to change that behavior.

Is that considered as a feature or could it be considered a bug?


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #97457: Use proper LinkFactory setup for newly added unit testsClosed2022-04-22

Actions
Actions #1

Updated by Georg Ringer almost 4 years ago

Hi Francois,

thanks for creating the issue!
What about providing a custom LinkBuilder in LocalConfiguration.php with FE|typolinkBuilder|page => YourClass, extend the PageLinkBuilder and implement it there.

I don't think that another event/hook is needed. Would it be ok to close the issue?

Actions #2

Updated by Georg Ringer almost 4 years ago

  • Status changed from New to Needs Feedback
Actions #3

Updated by Francois Suter almost 4 years ago

I hadn't thought about this possibility. I just felt that I might not be the only one having this need, but maybe I am ;-)

Also extending the PageLinkBuilder is not very convenient, because it's still quite monolithic. So I still think that it could be a worthwhile feature. OTOH I'm conscious that if I don't work on it myself, it's probably never going to happen...

My current workaround is to apply a patch to it on the fly using Composer.

Actions #4

Updated by Gerrit Code Review over 2 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 38 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72999

Actions #5

Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Stefan Bürk over 2 years ago

  • Related to Bug #97457: Use proper LinkFactory setup for newly added unit tests added
Actions #7

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF