Bug #92508
closedhook filterMenuPages never has access to config
100%
Description
Hooking functions created with
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/tslib/class.tslib_menu.php']['filterMenuPages'][]
(defined in TYPO3\CMS\Frontend\ContentObject\Menu\AbstractMenuContentObject)
never have access to the capsulated configuration as there isn't any function to expose the values.
For a bit more complicated challenges this hook is therefore useless.
The ugly but possible alternative is an XCLASS.
EDIT:
-----
More detailed, using the hook the following interface is mandatory:
/** * interface for classes which hook into AbstractMenuContentObject */ interface AbstractMenuFilterPagesHookInterface { /** * Checks if a page is OK to include in the final menu item array. * * @param array $data Array of menu items * @param array $banUidArray Array of page uids which are to be excluded * @param bool $spacer If set, then the page is a spacer. * @param \TYPO3\CMS\Frontend\ContentObject\Menu\AbstractMenuContentObject $obj The menu object * @return bool Returns TRUE if the page can be safely included. */ public function processFilter(array &$data, array $banUidArray, $spacer, AbstractMenuContentObject $obj); }
All the parameters of processFilter() are filled with values, but most of them can't be accessed because the are protected and never have getter-methods.
Updated by David Bruchmann about 4 years ago
Desired use-case was https://github.com/DavidBruchmann/menustop
Updated by Gerrit Code Review almost 3 years ago
- Status changed from New to Under Review
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72955
Updated by Gerrit Code Review almost 3 years ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72955
Updated by Gerrit Code Review almost 3 years ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72955
Updated by Gerrit Code Review almost 3 years ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72955
Updated by Benni Mack almost 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 45ae6943df9ed742abd35e754ec56904e67f71e5.
Updated by Benni Mack over 1 year ago
- Related to Task #101006: Remove deprecated functionality related to link handling and ContentObjectRenderer added
Updated by Benni Mack over 1 year ago
- Related to deleted (Task #101006: Remove deprecated functionality related to link handling and ContentObjectRenderer)
Updated by Benni Mack over 1 year ago
- Related to Task #101006: Remove deprecated functionality related to link handling and ContentObjectRenderer added