Bug #92655

checking for external URLs may cause link checking to never end

Added by Sybille Peters about 1 month ago. Updated 11 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2020-10-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I just had this in production. I am starting to increase page depth of scheduler tasks. One of the scheduler tasks never ended. Also, I noticed that several scheduler tasks were running.

So, I traced this down to an URL where the loading never ends. Why this is the case there, I don't know exactly. But is also not so relevant here.

This is a problem, because once only a single link in the site points to such a site, linkvalidator checks will not work, several scheduler tasks will run and eat up resources.

Reproduce

  1. Create a PHP page with infinite loop, e.g.
<?php
while (true) {

}

  1. create a link to to this page
  2. either start a scheduler task with linkvalidator or use "Check links"

The link checking or scheduler task will not finish.

#1

Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241

#2

Updated by Sybille Peters about 1 month ago

  • Description updated (diff)
#3

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241

#4

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241

#5

Updated by Gerrit Code Review about 1 month ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241

#6

Updated by Gerrit Code Review about 1 month ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241

#7

Updated by Sybille Peters about 1 month ago

It is already possible to set the timeout with $GLOBALS['TYPO3_CONF_VARS']['HTTP']['timeout'].

So if anyone is experiencing this problem, I would recommend to set the timeout there. By default it is 0, which means no timeout.

I think it is a problem to have no timeout by default. I have created a patch which sets it via TSConfig, but you can default to using the Global Configuration, if the TSconfig is unset: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241

#8

Updated by Gerrit Code Review 12 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241

#9

Updated by Gerrit Code Review 12 days ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241

#10

Updated by Gerrit Code Review 12 days ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66759

#11

Updated by Sybille Peters 12 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#12

Updated by Gerrit Code Review 12 days ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66759

#13

Updated by Sybille Peters 11 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF