Bug #92655
closed
checking for external URLs may cause link checking to never end
100%
Description
I just had this in production. I am starting to increase page depth of scheduler tasks. One of the scheduler tasks never ended. Also, I noticed that several scheduler tasks were running.
So, I traced this down to an URL where the loading never ends. Why this is the case there, I don't know exactly. But is also not so relevant here.
This is a problem, because once only a single link in the site points to such a site, linkvalidator checks will not work, several scheduler tasks will run and eat up resources.
Reproduce¶
- Create a PHP page with infinite loop, e.g.
<?php
while (true) {
}
- create a link to to this page
- either start a scheduler task with linkvalidator or use "Check links"
The link checking or scheduler task will not finish.
Updated by Gerrit Code Review about 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241
Updated by Gerrit Code Review about 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241
Updated by Gerrit Code Review about 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241
Updated by Gerrit Code Review about 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241
Updated by Gerrit Code Review about 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241
Updated by Sybille Peters about 4 years ago
It is already possible to set the timeout with $GLOBALS['TYPO3_CONF_VARS']['HTTP']['timeout'].
So if anyone is experiencing this problem, I would recommend to set the timeout there. By default it is 0, which means no timeout.
I think it is a problem to have no timeout by default. I have created a patch which sets it via TSConfig, but you can default to using the Global Configuration, if the TSconfig is unset: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241
Updated by Gerrit Code Review about 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241
Updated by Gerrit Code Review about 4 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241
Updated by Gerrit Code Review about 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66759
Updated by Sybille Peters about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 96cb0313f20ee9621af18f472d562c56709868f4.
Updated by Gerrit Code Review about 4 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66759
Updated by Sybille Peters about 4 years ago
- Status changed from Under Review to Resolved
Applied in changeset 6bf68b40801f7b5fc250edd41c38c993b995e1d8.
Updated by Benni Mack almost 4 years ago
- Status changed from Resolved to Closed