Project

General

Profile

Actions

Bug #92751

closed

Localization wizard hangs

Added by Dmitry Dulepov over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Localization
Target version:
-
Start date:
2020-11-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

Steps to reproduce:

  • Create a content element on the page
  • Localize that content element to another language
  • Create another content element in the same column below the first one
  • Change the first content element to language "All"
  • Press translate button in the Page module

Expected result:

  • You can translate the second element

Actual result:

  • Source language selection does not appear
  • List of records to localize does not appear
  • Clicking "Next" makes the window display spinning indicator forever

The cause

  • Query in LocalizationRepository::fetchOriginLanguage will fetch two languages: -1 and 0. The first one will be returned: -1
  • Since -1 is not localizable, it will be skipped, so there will be no source language to translate from
  • Since there is no source language, there will be no records to translate
  • The system does not expect to have a translation window when there is nothing to translate and will display the spinning wheel forever

Proposed fixes:

  • Changing language to -1 should delete all translations of the record
  • LocalizationRepository::fetchOriginLanguage should ignore language -1

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #92757: Localization from language "All" should not be possibleClosed2020-11-03

Actions
Actions #1

Updated by Dmitry Dulepov over 3 years ago

  • Target version deleted (Candidate for patchlevel)
Actions #2

Updated by Dmitry Dulepov over 3 years ago

  • Related to Bug #92757: Localization from language "All" should not be possible added
Actions #3

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66557

Actions #4

Updated by Dmitry Dulepov over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67014

Actions #6

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67015

Actions #7

Updated by Dmitry Dulepov over 3 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF