Bug #92783
closed
Record inserted on wrong pid
100%
Description
If a record is localized and then moved to another page(A), the l10n_source field of the translated record on the old page(B) points to a record on a different pid(A).
If you create a new content element after the moved item on the new page(A) and want to translate it, the translated record of the new element is inserted on the old pid(B) because TYPO3 selects the record before itself by order and then selects the localized record by l10n_source which is on the old page(B).
This can lead to strange situations if records are copied and/or moved to different pages.
In this commit, the behaviour to use the l10n_source rather than the l18n_parent was introduced:
https://github.com/TYPO3/TYPO3.CMS/commit/3c6cdaedd288a3514d48e99fe298870606769201
Updated by Christian Kuhn about 4 years ago
Patch pending with https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552 - no idea why forge did not pick that one up.
Updated by Gerrit Code Review about 4 years ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Markus Klein about 4 years ago
I didn't get the problem completely:
- What is moved, a translation or the original record?
- Where does the source point to, the default language or some other translation?
- Is the translation a free mode translation?
Updated by Philipp Parzer about 4 years ago
- The original record is moved - it is translated in free mode, so the translation doesn't get moved and stays on the old page (connected mode would move the translation too)
- The source of the translation still points to the original record which is now on another page
- As mentioned above its in free mode
If the moving process is correct or not, I cannot say - but nevertheless it should never ever happen, that a translation is inserted on another page, than the one I'm currently translating.
Updated by Gerrit Code Review about 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Philipp Parzer about 4 years ago
- Related to Bug #92198: Localize method gets wrong PID from records generated during former free mode translations added
Updated by Gerrit Code Review about 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review almost 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review almost 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Christian Kuhn over 3 years ago
Seems we're suffering from that in a project, too. Will fix / finish the patch now.
Updated by Gerrit Code Review over 3 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review over 3 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review over 3 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review over 3 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review over 3 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review over 3 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review over 3 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review over 3 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66552
Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68612
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68612
Updated by Philipp Parzer over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d5366226fd0562bb12f49f9959b46f6402796e62.
Updated by
Updated by Christian Kuhn about 3 years ago
- Related to Bug #93078: 9.5/10.4: DataHandler::getPreviousLocalizedRecordUid() does not check pid added