Project

General

Profile

Actions

Bug #93494

closed

Not possible to define limit for live search

Added by Torben Hansen almost 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-02-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Although the TYPO3 live search has a setter named setLimitCount, this function is never used to set the max. amount of search results in the live search, so the limit is currently hardcoded to 5 results in \TYPO3\CMS\Backend\Search\LiveSearch\LiveSearch

It should be possible by configuration to override the limit.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #92008: Make LiveSearch extensibleClosedAndreas Kienast2020-08-15

Actions
Related to TYPO3 Core - Feature #88992: Add "makeSearchStringConstraints" hook for LiveSearchClosed2019-08-21

Actions
Actions #1

Updated by Guido Schmechel over 3 years ago

Hi Torben, how did you imagine the configuration? I implemented a test with a PSR14 event and was able to manipulate the QueryBuilder object. Of course, this cannot be further configured for the pure editor, but the complete LiveSearch can only be controlled by integrators anyway => "@internal This class is a specific Backend controller implementation and is not considered part of the Public TYPO3 API."

So we could improve livesearch a bit with v11 and through events. Can you think of any other settings that you would like to control?

I could still imagine manipulating the entire search result at the end.

Actions #2

Updated by Torben Hansen over 3 years ago

Currently the max. amount of records to show is the only configurable option I could think of. But a PSR-14 event to manipulate the searchresult would also be great.

Actions #3

Updated by Guido Schmechel over 3 years ago

Actions #4

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68528

Actions #5

Updated by Guido Schmechel over 3 years ago

Hi Torben, thx for your answer. I just push the WIP patch for the QueryBuilderEvent. Maybe we can adjust/push the bigger approach in #92008 to have more possibilities in the LiveSearch.

Actions #6

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68528

Actions #7

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68528

Actions #8

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68528

Actions #9

Updated by Guido Schmechel almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions #11

Updated by Andreas Kienast about 2 years ago

  • Related to Feature #88992: Add "makeSearchStringConstraints" hook for LiveSearch added
Actions

Also available in: Atom PDF