TYPO3 Core

Jan,

Changing the temp folder to a public one would probably fix this.

Use Environment::getPublicPath() instead of Environment::getVarPath() in \TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\AbstractOnlineMediaHelper

Introduced here https://review.typo3.org/c/Packages/TYPO3.CMS/+/56413/9/typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php#122

But think that the transient folder is also not correct. Should be something like /assets/online-media-preview/

So result:

    /**
     * Get temporary folder path to save preview images
     *
     * @return string
     */
    protected function getTempFolderPath()
    {
        $path = Environment::getPublicPath() . '/assets/online-media-preview/';
        if (!is_dir($path)) {
            GeneralUtility::mkdir_deep($path);
        }
        return $path;
    }

The folder name was changed here https://review.typo3.org/c/Packages/TYPO3.CMS/+/46096/14/typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php#121 and

But I'm not 100% sure if this would be the correct solution. As this is only a temp file. Maybe the view shouldn't depend on this file, but the <f:image viewhelper should create a `_processed` file that would be in `typo3temp/assets`.

Start of the folder move was here https://review.typo3.org/c/Packages/TYPO3.CMS/+/45669/ and there is clearly states it should be a public folder.

I think it would be even better to rename the method:

    /**
     * Get publicly accessible temporary folder path to save preview images
     *
     * @return string
     */
    protected function getPublicTempFolderPath()
    {
        $path = Environment::getPublicPath() . '/assets/online-media-preview/';
        if (!is_dir($path)) {
            GeneralUtility::mkdir_deep($path);
        }
        return $path;
    }

Actually, the preview images should be special FAL images or processed files in the future, as the local setup completely bypasses any useful handling for our File-system abstraction layer.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69472

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69472

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70213