Feature #94162
open
Update Slughelper to allow both dash and lodash Characters
0%
Description
Hi there,
at the moment, the slughelper converts both dash and lodash to the fallback character -
typo3/sysext/core/Classes/DataHandling/SlugHelper.php:115
// Convert some special tokens (space, "_" and "-") to the space character
$fallbackCharacter = (string)($this->configuration['fallbackCharacter'] ?? '-');
$slug = preg_replace('/[ \t\x{00A0}\-+_]+/u', $fallbackCharacter, $slug);
Page title with - and _ xis converted to:
page-title-with-and-x
Since both Characters are valid for urls, it would be good if there would be at least the option to keep these characters,
so that the result would be
page-title-with-and-_-x
Files
Updated by Stefan Bürk over 3 years ago
Forget to note here ... I worked on it to .. but as you wrote in general/general in discord, and I'm in remote sprint/general did not see it.
I'm ready to push a patch, done the work with tests .. wrote in discord.
Should i push mine ? or how should we solve this "double work conflict" ?
Updated by Christine Zoglmeier over 3 years ago
Go ahead and push yours. I will compare your solution with mine.
Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review over 3 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review about 3 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review about 3 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Benni Mack about 3 years ago
- Target version changed from 11.4 to 12 LTS
Updated by Gerrit Code Review about 3 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review about 3 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review almost 3 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Gerrit Code Review almost 3 years ago
Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Oliver Hader almost 3 years ago
- Related to Bug #94693: Slug fieldSeparator (and replacements) replaced by fallbackCharacter added
Updated by Eric Harrer almost 3 years ago
- File core-10.4.21.patch core-10.4.21.patch added
Is it possible to extend the official support for this feature to typo3 10 and 11?
Based on this patch, I created a patch file for TYPO3 version 10. Maybe it will be of use to someone.
Updated by Simon Gilli almost 3 years ago
@eric as we are talking about a feature here the chances are really small to get the permission for a backport. The policy is clear, no features are backported normally.
Updated by Gerrit Code Review over 2 years ago
Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70481
Updated by Oliver Hader about 2 years ago
- Sprint Focus set to On Location Sprint
Updated by Benni Mack over 1 year ago
- Target version changed from 12 LTS to Candidate for Major Version
Updated by Benni Mack over 1 year ago
- Sprint Focus deleted (
On Location Sprint)