Project

General

Profile

Actions

Feature #94191

closed

Performance improments for \TYPO3\CMS\Core\TypoScript\TemplateService\addExtensionStatics()

Added by Tee Ohh almost 3 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Performance
Start date:
2021-05-25
Due date:
% Done:

0%

Estimated time:
PHP Version:
7.4
Tags:
Complexity:
Sprint Focus:

Description

This function checks for every activated extension if ext_typoscript_constants.txt, ext_typoscript_constants.typoscript, ext_typoscript_setup.txt and ext_typoscript_setup.typoscript exists. If an installation have many extensions, this generates a lot of I/O. My question: It is possible to change this function to make this file checks only if this files are registered in the extension (e.g. in ext_localconf.php)?

If you want to add PageTSConfig, you must also register the file in ext_localconf.php.

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPageTSConfig(
'@import "EXT:your_ext_key/Configuration/TSConfig/tsconfig.tsconfig"'
);

Maybe the location of this files should be in 'Configuration/TypoScript/'. This brings the TypoScript definitions together at one location and clean up the root extension directory.

An other option could be to cache this files like it is done for ext_tables.php as well as ext_localconf.php.

Actions #1

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69257

Actions #2

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69257

Actions #3

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69257

Actions #4

Updated by Benni Mack almost 3 years ago

  • Target version changed from 11.3 to 11.4
Actions #5

Updated by Riccardo De Contardi almost 3 years ago

  • Category set to Performance
Actions #6

Updated by Andreas Kienast over 2 years ago

  • Status changed from Under Review to New
Actions #7

Updated by Benni Mack over 2 years ago

  • Target version changed from 11.4 to Candidate for Major Version
Actions #8

Updated by Christian Kuhn over 2 years ago

  • Status changed from New to Rejected

Closing this for now: The issue is bigger and a patch adding a cache layer did not make it. This issue will probably resolve itself when we rewrite the ts parser once and for all.

Actions

Also available in: Atom PDF