Feature #94280
closedUsing global namespace for cached version of ext_localconf and ext_tables
100%
Description
Is there any reason not to use global namespace statements when concatenating all ext_localconf resp. ext_table files?
Creating the cached file like
/**
* Compiled ext_localconf.php cache file
*/
/**
* Extension: core
* File: .../typo3/sysext/core/ext_localconf.php
*/
namespace {
// content of typo3/sysext/core/ext_localconf.php
}
/**
* Extension: core
* File: .../typo3/sysext/extbase/ext_localconf.php
*/
namespace {
// content of typo3/sysext/extbase/ext_localconf.php
}
...
would relax some rules and allow use statements in those files, which would improve readability and maintainability for extensions.
As up to now no one could introduce namespaces in those files or shouldn't use use statements, it should be safe to introduce this simple wrapper.
I also could not think of any downside and suppose performance wouldn't be influenced in any way.
Any thoughts on this?
Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70548
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70548
Updated by Gerrit Code Review about 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70548
Updated by Gerrit Code Review about 3 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70548
Updated by Wouter Wolters about 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a5e3c21b848af4ae07089166fae6ed9aa3d53814.
Updated by Andreas Kienast about 3 years ago
- Related to Task #94983: Add Important.rst for #94280 added
Updated by Wouter Wolters about 3 years ago
- Related to Task #94984: Declare strict types in ext_tables.php files added
Updated by Markus Klein about 3 years ago
- Related to Task #94985: Use import instead of FQCN in ext_tables.php files added