Bug #94655: Slug generation for records with pid=0 always returns "/" - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #94655

closed

Slug generation for records with pid=0 always returns "/"

Added by Rudy Gnodde over 3 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

11 LTS

Start date:

2021-07-28

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.4

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

I've added a slug field to records that have pid=0. The generated slug is always /. The cause for this is a hardcoded check in the generate function in TYPO3\CMS\Core\DataHandling\SlugHelper:

if ($pid === 0 || (!empty($recordData['is_siteroot']) && $this->tableName === 'pages')) {
    return '/';
}

The check for pid=0 makes sense for pages, but not for other record types.

I've checked this in TYPO3 10 and 11.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Mathias Brodala over 3 years ago

Description updated (diff)

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70122

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70122

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70122

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70122

Actions

Copy link

Updated by Rudy Gnodde over 3 years ago

Target version set to 11.4

Actions

Copy link

Updated by Gerrit Code Review about 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70122

Actions

Copy link

Updated by Benni Mack about 3 years ago

Target version changed from 11.4 to 11 LTS

Actions

Copy link

Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71059

Actions

Copy link

#10