Bug #95095
closedProperties of Extbase OriginalRequest get overwritten on forward
100%
Description
Propably with the change #94428 the behavior of a ForwardRequest in Extbase changed. In TYPO3\CMS\Extbase\Mvc\Dispatcher::buildRequestFromCurrentRequestAndForwardResponse(Request $currentRequest, ForwardResponse $forwardResponse)
the given $currentRequest
is cloned to $request
variable and next controller name, extension name and arguments get set for the cloned request object .
Since the cloned request object internally holds a reference to original the PSR-7 request, controller name, extension name and arguments actually get overwritten with data from the forwarded request.
To visualize this, please see the following screenshots.
This is the state right after $currentRequest
is cloned to $request
. Note, that arguments
in ExtbaseRequestParameters
contains 4 items.
This is the state of $currentRequest
after controller name, extension name and arguments were changed in $request
. So basically we loose important information about the original request here.
It seems to me, that this new behavior is unintended any may lead to problems for extension authors relying on data in OriginalRequest
Files
Updated by Christian Kuhn about 3 years ago
- Related to Feature #94428: Extbase Request implements ServerRequestInterface added
Updated by Christian Kuhn about 3 years ago
- Related to Bug #94457: Always override new request arguments when forwarding added
Updated by Torben Hansen about 3 years ago
- Related to Bug #95281: Form values from submitted data are missing when validation fails added
Updated by Gerrit Code Review about 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71133
Updated by Gerrit Code Review about 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71133
Updated by Gerrit Code Review about 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71133
Updated by Gerrit Code Review about 3 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71133
Updated by Gerrit Code Review about 3 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71133
Updated by Torben Hansen about 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 63137e4392610d1ff3ea38e70ab34941270caae8.