Project

General

Profile

Actions

Task #95203

closed

checkFilePermissions checks file permissions that are not tracked in git

Added by Jonas Eberle over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-09-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

For normal files, it checks if they are exactly 644.

That check is too narrow since git does only manage the executable bit for the user. So the actual file permissions are dependent on the system environment.

Just to showcase it:

$ umask
0002
$ git clone git@github.com:typo3/typo3 0002
...
$ ls -l 0002/typo3/README.md
-rw-rw-r-- 1 jonas jonas 6611 Sep 12 17:44 0002/typo3/README.md
$ umask 0077
$ git clone git@github.com:typo3/typo3 0077
...
$ ls -l 0077/typo3/README.md
-rw------- 1 jonas jonas 6611 Sep 12 17:44 0077/typo3/README.md
$ cd 0077 && git ls-files -s README.md 
100644 4c60da23261803f7f82b2a08b0a88e41bfde6877 0       README.md

Even if file permissions differ, `git status` shows them as unchanged (and that is legit since it really only remembers if a file is +x or -x). The output of `git ls-files -s` is misleading since it "beautifies" it as 755/644.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #95201: Enforce temporarly GIT clone strategory for gitlab runner checkoutsRejected2021-09-12

Actions
Actions #1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046

Actions #2

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046

Actions #3

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046

Actions #4

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046

Actions #5

Updated by Christian Kuhn over 2 years ago

  • Related to Task #95201: Enforce temporarly GIT clone strategory for gitlab runner checkouts added
Actions #6

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71052

Actions #7

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71053

Actions #8

Updated by Anonymous over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF