Task #95203
closedcheckFilePermissions checks file permissions that are not tracked in git
100%
Description
For normal files, it checks if they are exactly 644.
That check is too narrow since git does only manage the executable bit for the user. So the actual file permissions are dependent on the system environment.
Just to showcase it:
$ umask 0002 $ git clone git@github.com:typo3/typo3 0002 ... $ ls -l 0002/typo3/README.md -rw-rw-r-- 1 jonas jonas 6611 Sep 12 17:44 0002/typo3/README.md $ umask 0077 $ git clone git@github.com:typo3/typo3 0077 ... $ ls -l 0077/typo3/README.md -rw------- 1 jonas jonas 6611 Sep 12 17:44 0077/typo3/README.md $ cd 0077 && git ls-files -s README.md 100644 4c60da23261803f7f82b2a08b0a88e41bfde6877 0 README.md
Even if file permissions differ, `git status` shows them as unchanged (and that is legit since it really only remembers if a file is +x or -x). The output of `git ls-files -s` is misleading since it "beautifies" it as 755/644.
Updated by Gerrit Code Review about 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046
Updated by Gerrit Code Review about 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046
Updated by Gerrit Code Review about 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046
Updated by Gerrit Code Review about 3 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046
Updated by Christian Kuhn about 3 years ago
- Related to Task #95201: Enforce temporarly GIT clone strategory for gitlab runner checkouts added
Updated by Gerrit Code Review about 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71052
Updated by Gerrit Code Review about 3 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71053
Updated by Anonymous about 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 13aac0c3355a4a210bf3cbba674fa9e54650e191.