Project

General

Profile

Actions

Bug #95686

closed

Change Paginator and Pagination final classes to virtual classes

Added by S P almost 3 years ago. Updated 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-10-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Currently the core-shipped Paginator and Pagination classes are declared final .

I want to override them to change a small detail in their implementation for my specific project. I can not do so because of final , but have to copy-paste most of it instead of just extend-ing them.

TYPO3 provides an API framework to extend on, not a "finished" ready-for-market software, so no public API classes should ever be final (only purely internal non-public-API classes may be final).


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #89603: Introduce native pagination for listsClosedAlexander Schnitzler2019-11-07

Actions
Actions #1

Updated by Oliver Hader almost 3 years ago

  • Related to Feature #89603: Introduce native pagination for lists added
Actions #2

Updated by Georg Ringer 2 months ago

  • Status changed from New to Closed

I am closing this issue. If there is a real bug, feel free to open a new issue for that.

there is a big discussion in the whole PHP world about using final in code. TYPO3 switched some parts to final, e.g. the VH (See https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Important-95298-FluidViewhelpersWillBeDeclaredFinalInV12.html)

especially if there is an API available it can be absolutly useful to use final even though I understand that copy/paste is a bad or at at least undesired habit.

Actions

Also available in: Atom PDF