Actions
Bug #95714
openOmit attributes with blank values for additionalAttributes in VideoTagRenderer
Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2021-10-20
Due date:
% Done:
0%
Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Description
VideoTagRenderer.php implodes attributes with $dontOmitBlankAttribs = true
.
$attributes[] = GeneralUtility::implodeAttributes($options['additionalAttributes'], true, true);
This could create problems like in this use case:
Example:
<f:media ... additionalAttributes="{poster: '{v:media.exists(file: \'fileadmin/test.jpg\', then: \'/fileadmin/test.jpg\')}', no-cookie: 1, relatedVideos: 0, color: 'white', playsinline: '1'}" />
In this case, AFAIK, it's not possible to omit the attribute 'poster' in Fluid. So, if file doesn't exist the attribute will still be present with an empty value but the use case wants that if a poster is not available for the video then the attribute must not be present.
I don't know if there are use cases that needs $dontOmitBlankAttribs = true
but I think that it should be false.
Actions