Project

General

Profile

Actions

Bug #96230

closed

Login Failure Warning Email : missing RemoteAdress and siteURL

Added by RVVN no-lastname-given almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-12-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi,

the fluid email we receive after some failed login attempts at backend is missing 2 informations :

  • remoteAdress
  • siteURL

There have been some attempts (4) to login at the TYPO3 site "Crespin" (). 

This is a dump of the failures:
02-12-21 13:20: Login-attempt from XXX.XXX.XXX.XXX, username 'johndoe' not found!!
02-12-21 13:21: Login-attempt from XXX.XXX.XXX.XXX, username 'johndoe', password not accepted!
02-12-21 13:24: Login-attempt from XXX.XXX.XXX.XXX, username 'johndoe', password not accepted!
02-12-21 13:26: Login-attempt from XXX.XXX.XXX.XXX, username 'johndoe', password not accepted!

This email was sent by Crespin from URL: - Please contact your site administrator if you feel you received this email by accident.

Some code inspection and debug lead me to an empty value for $GLOBALS['TYPO3_REQUEST']

The issue doesn't occur with the Login Warning email, so I mimicked the code and tried this workaround in typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php :

2483         /*if ($GLOBALS['TYPO3_REQUEST'] instanceof ServerRequestInterface)      {
2484             $email->setRequest($GLOBALS['TYPO3_REQUEST']);
2485         }*/
2486         $email->setRequest($GLOBALS['TYPO3_REQUEST'] ?? \TYPO3\CMS\Core\Http\ServerRequestFactory::fromGlobals()); //RVVN

Related issues 1 (1 open0 closed)

Related to TYPO3 Core - Bug #100148: layout SystemEmail should not show URL if URL is not setUnder ReviewSybille Peters2023-03-12

Actions
Actions #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77943

Actions #2

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77943

Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77943

Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77943

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77943

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77943

Actions #7

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77943

Actions #8

Updated by J. Peter M. Schuler over 1 year ago

  • Related to Bug #100148: layout SystemEmail should not show URL if URL is not set added
Actions #9

Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77943

Actions #10

Updated by Stefan Bürk over 1 year ago

  • Status changed from Under Review to Closed

abandoned - fixed in v12 and v13

Actions

Also available in: Atom PDF