Bug #96332
closed
Dependency injection not working for extbase validators
100%
Description
(Found by testing powermail in TYPO3 version 11.)
In \TYPO3\CMS\Extbase\Mvc\Controller\ActionController->initializeActionMethodValidators() the validators are instantiated by calling
$validatorInstance = GeneralUtility::makeInstance(
$validatorDefinition['className'],
$validatorDefinition['options']
);
however, when options for the given validator are empty, the empty array will get passed to GeneralUtility::makeInstance() as the first argument. Therefore, the check for empty constructorArguments will fail in GeneralUtility::makeInstance() and the class will not be instantiated by the DI container.
Updated by Philipp Thiele about 3 years ago
- Description updated (diff)
- Target version deleted (
Candidate for patchlevel)
Updated by Christian Kuhn almost 3 years ago
- Related to Task #95026: [TASK] Add missing breaking.rst about service injection in Extbase validators added
Updated by Christian Kuhn almost 3 years ago
- Related to Task #92238: Avoid usage of object manager in validation related classes added
Updated by Christian Kuhn almost 3 years ago
- Related to Task #94451: Avoid ObjectManager in ext:extbase added
Updated by Gerrit Code Review almost 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Christian Kuhn almost 3 years ago
- Related to Task #94384: Avoid ObjectManager in remaining ext:form places added
Updated by Gerrit Code Review almost 3 years ago
Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 4 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 5 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 6 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 7 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 8 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 9 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 10 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73631
Updated by Gerrit Code Review almost 3 years ago
Patch set 11 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73631
Updated by Gerrit Code Review almost 3 years ago
Patch set 12 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73631
Updated by Gerrit Code Review almost 3 years ago
Patch set 13 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73630
Updated by Gerrit Code Review almost 3 years ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73631
Updated by Christian Kuhn almost 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 78fa14c15878a5641cc0e01851e3ef8281286444.
Updated by Christian Kuhn almost 3 years ago
- Related to Task #96998: Streamline Extbase validators added
Updated by