Project

General

Profile

Actions

Bug #96503

closed

Commented out TypoScript imports still resolved.

Added by Lina Wolf almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
TypoScript
Target version:
-
Start date:
2022-01-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I have a bunch of imports in my setup.typoscript that for some reason mess up my system and made the backend freeze due to a circular include.

It turns out that an import within a block-comment is still executed:

/*
@import 'EXT:fluid_styled_content/Configuration/TypoScript/setup.typoscript'
...
*/

/*

### @import 'EXT:fluid_styled_content/Configuration/TypoScript/setup.typoscript' begin ###

# Include setup

### <INCLUDE_TYPOSCRIPT: source="FILE:EXT:fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.typoscript"> BEGIN:
# Default configuration for content elements which are using FLUIDTEMPLATE directly
lib.contentElement >
lib.contentElement = FLUIDTEMPLATE

...

So a circular includes within a block-comment still makes the backend freeze.

imports within single line comments are however not executed:

# @import 'EXT:fluid_styled_content/Configuration/TypoScript/setup.typoscript'

If this is not a bug but a feature we would need to document it better...


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #97816: New TypoScript parserClosed2022-06-27

Actions
Actions #1

Updated by Oliver Hader almost 3 years ago

  • Description updated (diff)
Actions #2

Updated by Oliver Hader almost 3 years ago

  • Description updated (diff)
Actions #3

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73019

Actions #4

Updated by Christian Kuhn over 2 years ago

Actions #5

Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987

Actions #6

Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987

Actions #7

Updated by Gerrit Code Review over 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987

Actions #8

Updated by Gerrit Code Review over 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74987

Actions #9

Updated by Christian Kuhn over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF