Project

General

Profile

Actions
Copy link

Task #96706

closed

Remove broken test from ServiceProviderCompilationPassTest

Added by Benjamin Franzke almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2022-01-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not containa a proper test
setup, which went undetected as the expected TypeError
was thrown for the invalid test setup.

This could have been fixed but the test actually only
tried to assert whether a callable type declaration is set,
in order to test whether a PHP error is thrown when an
invalid factory is provided. This is useless as an
invalid factory will result in an error in any case,
once tried to be called.

Actions
Copy link

Also available in: Atom PDF