Bug #96713: Fix incorrect Prophecy usages - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Bug #96713

closed

Fix incorrect Prophecy usages

Added by Oliver Klee almost 3 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Code Cleanup

Target version:

12 LTS

Start date:

2022-01-31

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

- remove almost as many Prophecy-related warnings from the PHPStan baseline as possible
- fix incorrect type annotations for prophecies
- use native type annotations for prophecies
- remove redundant type annotations with Prophecy that are already covered by the PHPStan Prophecy plugin

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #96725: Use generics for ObjectProphecy class properties

Closed

2022-02-01

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Oliver Klee almost 3 years ago

Subject changed from Fix incorrect Prophecy usage to Fix incorrect Prophecy usages

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Status changed from New to Under Review

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73238

Actions

Copy link

Updated by Oliver Klee almost 3 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset f32fdb1611bdc2ee501613e40d4850a54e8f647d.

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73257

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73257

Actions

Copy link

#10

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73257

Actions

Copy link

#11